Keru/knowledge-genome-orchestrator
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor(ingest): Enhance run-ingest.sh for testability and robustness

Browse source
This commit is contained in:
Matteo Cherubini 2026-06-04 10:59:09 +02:00
parent e531135bf3
commit ff0828f5a7
2 changed files with 11 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
skills/ingest/scripts/open-pr.sh
View file

@ -46,6 +46,12 @@ fi
git commit -m "$title" git commit -m "$title"
git push -u origin "$branch" git push -u origin "$branch"
# DRY_RUN: local git work done; skip the Forgejo API (offline tests).
if [[ -n "${DRY_RUN:-}" ]]; then
echo "PR opened: DRY-RUN ${branch} -> ${base}"
exit 0
fi
# 2. Open the PR via Forgejo API (jq builds the JSON safely) # 2. Open the PR via Forgejo API (jq builds the JSON safely)
body="$(cat "$body_file")" body="$(cat "$body_file")"
payload="$(jq -n --arg head "$branch" --arg base "$base" \ payload="$(jq -n --arg head "$branch" --arg base "$base" \

10
skills/ingest/scripts/run-ingest.sh
View file

@ -16,7 +16,7 @@ manifest="${2:-.ingest-manifest.json}"
SCRIPTS="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" SCRIPTS="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
fail() { fail() {
jq -n --arg stage "$1" --arg reason "$2" \ jq -nc --arg stage "$1" --arg reason "$2" \
'{status:"error", stage:$stage, reason:$reason}' '{status:"error", stage:$stage, reason:$reason}'
exit 1 exit 1
} }
@ -72,12 +72,12 @@ done < <(jq -r '.pages[] | select(.status=="created")
# --- 2. log entry --- # --- 2. log entry ---
out="$(jq -r '[.pages[].path | "[[" + (sub("^wiki/";"") | sub("\\.md$";"")) + "]]"] | join(", ")' "$manifest")" out="$(jq -r '[.pages[].path | "[[" + (sub("^wiki/";"") | sub("\\.md$";"")) + "]]"] | join(", ")' "$manifest")"
"${SCRIPTS}/log-append.sh" --type INGEST --subject "$slug" --model "$model" \ bash "${SCRIPTS}/log-append.sh" --type INGEST --subject "$slug" --model "$model" \
--context "[[${raw_source}]]" --output "${out:-*(none)*}" --reasoning "$reasoning" \ --context "[[${raw_source}]]" --output "${out:-*(none)*}" --reasoning "$reasoning" \
|| fail "log" "log-append failed" || fail "log" "log-append failed"
# --- 3. scoped lint (capture findings for the PR; never aborts the run) --- # --- 3. scoped lint (capture findings for the PR; never aborts the run) ---
lint_out="$( "${SCRIPTS}/scoped-lint.sh" "$genome" "${all_paths[@]}" 2>&1 )" && lint_rc=0 || lint_rc=$? lint_out="$( bash "${SCRIPTS}/scoped-lint.sh" "$genome" "${all_paths[@]}" 2>&1 )" && lint_rc=0 || lint_rc=$?
# --- 4. assemble the PR body (manifest tables + lint results) --- # --- 4. assemble the PR body (manifest tables + lint results) ---
body="$(mktemp)" body="$(mktemp)"
@ -102,13 +102,13 @@ body="$(mktemp)"
# --- 5. open the PR --- # --- 5. open the PR ---
pr_args=( --slug "$slug" --title "feat: ingest ${slug}" --body-file "$body" ) pr_args=( --slug "$slug" --title "feat: ingest ${slug}" --body-file "$body" )
[[ -n "$conflict_label" ]] && pr_args+=( --label "$conflict_label" ) [[ -n "$conflict_label" ]] && pr_args+=( --label "$conflict_label" )
pr_out="$( "${SCRIPTS}/open-pr.sh" "${pr_args[@]}" 2>&1 )" && pr_rc=0 || pr_rc=$? pr_out="$( bash "${SCRIPTS}/open-pr.sh" "${pr_args[@]}" 2>&1 )" && pr_rc=0 || pr_rc=$?
pr_url="$(printf '%s\n' "$pr_out" | sed -n 's/^PR opened: //p' | head -n1)" pr_url="$(printf '%s\n' "$pr_out" | sed -n 's/^PR opened: //p' | head -n1)"
rm -f "$body" rm -f "$body"
# --- final result line for n8n --- # --- final result line for n8n ---
jq -n \ jq -nc \
--arg status "$([[ $pr_rc -eq 0 ]] && echo ok || echo pr_failed)" \ --arg status "$([[ $pr_rc -eq 0 ]] && echo ok || echo pr_failed)" \
--arg slug "$slug" \ --arg slug "$slug" \
--arg pr_url "$pr_url" \ --arg pr_url "$pr_url" \